On Tue, Oct 5, 2010 at 2:16 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Shawn Pearce wrote: > >> This change only removes the deflate copy. ÂBut due to the SHA-1 >> consistency issue I alluded to earlier, I think we're still making a >> full copy of the file in memory before we SHA-1 it or deflate it. > > Hmm, I _think_ we still use mmap for that (which is why 748af44c needs > to compare the sha1 before and after). Just tried valgrind massif on a 200MB file with master. It used ~270kb heap. I haven't tested but I believe git-checkout will keep the whole inflated copy in memory. So git-add alone does not help much. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html