Re: [PATCHv6 07/16] t3600 (rm): add lots of missing &&

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

> Maybe you would prefer something like this on top?  My only concern is
> to make sure the test is robust (even if people add new tests before
> these without paying much attention) and easy to read.
>
> I suppose I am nitpicking excessively because I do not like to see
> regressions, even in out-of-the-way code like this.

I do not think you are nitpicking at all; it is a key to maintainability
to make sure that the code is unlikely to be broken by future changes that
are not perfectly diligent.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]