Re: [PATCH 6/n] gitweb: Remove redundant "blob" links from git_difftree_body

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> ... First, it did that incompletely: it did not add "blob"
> link for added files, and added block used mixture of tabs and spaces
> for align. Second, in "difftree" view the "blob" link is not the most
> interesting, *contrary* to "blob"/"tree" link in "tree" view, so it
> should be enough to have hidden link in the form of file name entry.

I think these "blob" links are good thing to have, and if you
think the earlier work was incomplete and know some cases are
not covered I think it would be better to help completing it
rather than reverting.

I do not understand why you feel "blob" is not the most
interesting.  Often, when it is not obvious if a patch is
correct only with the context, it is useful to view the whole
postimage after applying the patch, and the "blob" link helps
that.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]