On Sonntag, 3. Oktober 2010, Ãvar ArnfjÃrà Bjarmason wrote: > @@ -1350,6 +1354,11 @@ ifdef NO_FNMATCH > COMPAT_CFLAGS += -DNO_FNMATCH > COMPAT_OBJS += compat/fnmatch/fnmatch.o > endif > +ifdef NO_FNMATCH_CASEFOLD > + COMPAT_CFLAGS += -Icompat/fnmatch > + COMPAT_CFLAGS += -DNO_FNMATCH_CASEFOLD > + COMPAT_OBJS += compat/fnmatch/fnmatch.o > +endif I think you should protect against defining both NO_FNMATCH and NO_FNMATCH_CASEFOLD (your version would link compat/fnmatch/fnmatch.o twice in this case): ifdef NO_FNMATCH ... else ifdef NO_FNMATCH_CASEFOLD ... endif endif Otherwise, the patch looks fine. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html