Re: [PATCH] test-lib: make test_expect_code a test command

[Sverre Rabbelier <srabbelier@xxxxxxxxx>]

Heya,

On Fri, Oct 1, 2010 at 19:16, Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> wrote:
> converted that code to use an external test similar no the TODO test I

s/no/to/
> +cat >expect <<EOF &&
> +not ok - 1 tests clean up even after a failure
> +#
> +# Â Â Â Â Âtouch clean-after-failure &&
> +# Â Â Â Â Âtest_when_finished rm clean-after-failure &&
> +# Â Â Â Â Â(exit 1)
> +#
> +not ok - 2 failure to clean up causes the test to fail
> +#
> +# Â Â Â Â Âtest_when_finished \"(exit 2)\"
> +#
> +# failed 2 among 2 test(s)
> +1..2
> +EOF
> + Â Âtest_cmp expect out)

I still like the putting-the-code-in-a-separate-harness, but I'm
wondering if we can't come up with something better than comparing
with test output that could change in the future... unless we decide
to standardize on TAP and not deviate from it? Either case, wouldn't
it at least be a good idea to get rid of the parts after the # in the
comparrison?

-- 
Cheers,

Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html