Hi, On Wed, Sep 29, 2010 at 04:02:01PM -0700, Chris Packham wrote: > On 29/09/10 15:21, Jens Lehmann wrote: > > Am 29.09.2010 22:28, schrieb Chris Packham: > >> When the --recurse-submodules option is given git grep will search in > >> submodules as they are encountered. > > > > As "git clone" already introduced a "--recursive" option for > > submodule recursion IMO "--recursive" should be used here too for > > consistency. (Maybe you took the idea to use "--recurse-submodules" > > from my "git-checkout-recurse-submodules" branch on github? But that > > is only used there because I didn't get around to change it yet like > > I did in the "fetch-submodules-too" branch). > > I actually started with --recursive and switched to > --recurse-submodules. One thing with this is the standard grep > --recursive option which may cause some confusion if people expect git > grep to behave like normal grep. I'll switch to using --recursive for > now until someone objects to the potential confusion. How about dropping the option all together and making grep search all populated submodules by default and maybe have an option to turn it off. Since git grep is searching recursive by default this would be what I would expect as a user. Are there other reasons to turn off the search in submodules than the potential runtime penalty because of forks? > One more thought on this that has been hanging around in my mind. I > sometimes want to do something on all but one submodule, in this case > with grep I'm fairly likely to want to skip a linux repository because I > already know the thing I'm looking for is in userland. Maybe in the > future we can make --recursive take an argument that allows us to > specify/restrict which submodules get included in the command invocation. Thinking about this how about not providing a disable submodule recursion option at all? Just provide an --exclude option and let it be used transparently for both normal subfolders and submodules? Cheers Heiko -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html