Re: [PATCHv4 15/15] Replace "unset VAR" with "unset VAR;" in testsuite as per t/README

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> They break the && cascades, but aren't the && cascades already
> inherently broken due to the unportable return value of unset?

Of course; that is the breakage you are trying to fix, no?  My comment was
that I understand you are trying to, but the patch is not actually fixing
it.

If anything, it is making it worse. Earlier we would have got a false
breakage that would make people notice and take a look. With your patch
applied, we instead would let a breakage in parts earlier than these
"unset VAR;" go unnoticed, no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]