On Thu, 2 Nov 2006, Nicolas Pitre wrote:
> Another area of that patch I'm not really sure of is this:
>
> @@ -408,6 +415,7 @@ fetch_main () {
> append_fetch_head "$sha1" "$remote" \
> "$remote_name" "$remote_nick" "$local_name" "$not_for_merge"
> done
> + if [ "$pack_lockfile" ]; then rm -f "$pack_lockfile"; fi
> ) || exit ;;
> esac
>
> How can I make sure to not clobber a non-zero return code with the rm
> that would prevent the exit while still performing the rm in all cases?
OK looking at it again I think the || exit is only meant to match the
exit 1 before that point. Since this is a subshell then the exit 1
wouldn't exit it all on its own. Otherwise there is no errors expected
to trickle out of the while loop and I _think_ the above is correct.
Do you still want a new patch for the micronit quoting issue?
Nicolas
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html