2010/9/27 Jakub Narebski <jnareb@xxxxxxxxx>: > On Fri, 24 Sep 2010, Giuseppe Bilotta wrote: > >> The routine creates a table row with a name and a repository address, >> like the one used at the top of summary view. > [...] > >> +sub git_repo_url { >> + my ($name, $url) = @_; >> + return "<tr class=\"metadata_url\"><td>$name</td><td>$url</td></tr>\n"; >> +} > > It should be *format_repo_url*, and not git_repo_url, isn't it? Right. > By the way, doesn't gitweb include code dealing with repository URL; > why you don't _use_ this subroutine, then? The only code for the display of a repo URL is inlined into summary view, which in the next patch uses this function to do the display. I can probably squash them together. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html