Re: [RFC PATCHv2 16/16] Add missing &&'s throughout the testsuite

[Elijah Newren <newren@xxxxxxxxx>]

On Fri, Sep 24, 2010 at 5:18 PM, Ãvar ArnfjÃrà Bjarmason
<avarab@xxxxxxxxx> wrote:
> On Fri, Sep 24, 2010 at 22:22, Elijah Newren <newren@xxxxxxxxx> wrote:
>> Â Â Â Â(
>> - Â Â Â Â Â Â Â unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG
>> + Â Â Â Â Â Â Â unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG &&
>
> These are all bad, see c289c315c2bfcd5fde99f9e4dbb109f89e29dfce for
> why. If it's possible maybe we should have a new:
>
> Â Âtest_returns_whatever unset FOO &&
>
> To make this more self-documenting

Isn't that what test_might_fail does (even if documented as being only
for git commands)?

<snip>

Thanks for all the feedback!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html