Re: [PATCH v4 2/4] rev-parse: add tests for git rev-parse --flags.

Jon Seymour <jon.seymour@xxxxxxxxx> · Sun, 26 Sep 2010 02:19:59 +1000

On Sun, Sep 26, 2010 at 12:27 AM, Ãvar ArnfjÃrÃ Bjarmason
<avarab@xxxxxxxxx> wrote:
> On Sat, Sep 25, 2010 at 13:33, Jon Seymour <jon.seymour@xxxxxxxxx> wrote:
>
>> + Â Â Â : >expected &&
>
> We've been dropping the ":>foo" style in favor of ">foo" in other
> tests. There's no need for the ":".
>
>> + Â Â Â echo -X > expected &&
>> + Â Â Â echo -q > expected &&
>> + Â Â Â echo -X > expected &&
>> + Â Â Â echo --no-flags > expected &&
>
> Maybe some echo implementations don't like flag-like params, and we need:
>
> Â Âprintf "%s\n" "-X"
>
> here. I don't know whether that's the case.
>

Thanks for the review.

My latest revision incorporates this feedback, although I didn't use
extra quotes around -X. (e.g. I wrote printf "%s\n" -X)

jon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html