Jeff King <peff@xxxxxxxx> writes: > On Fri, Sep 24, 2010 at 10:55:08PM +0000, Ævar Arnfjörð Bjarmason wrote: > > > On Fri, Sep 24, 2010 at 22:22, Elijah Newren <newren@xxxxxxxxx> wrote: > > > FIXME: Is it intended that this git config --unset fail? I had to add a > > > test_might_fail as well. > > > > Presumably this is to work around the user having diff.color in his > > config or something? Should we be leaking like that? > > No, it was to clean up from previous tests, which set diff.color.new, to > make sure we had a clean environment. So it should have been might_fail > (but it predated might_fail, which is why it wasn't). Shouldn't modern test script use 'test_when_finished <script>' for cleanup instead? > But look at 8b124135, which came later. It changed the color() and > invalid_color() helpers to no longer use diff.color.new, so that cleanup > is now obsolete. So that line can simply be removed now. Well, there is that. -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html