On Sep 24, 2010, at 11:32 PM, Jon Seymour wrote:
> due to a faulty assumption that:
> git rev-parse --no-revs -- stash@{0}
This assumption is faulty, it should be "git rev-parse --no-revs --flags stash@{0}", which works properly for all revision arguments and flags _except_ -q and --quiet.
> This revision further simplifies the parsing code
> by removing use of git rev-parse for FLAGS parsing
> altogether.
That is simpler, and does fix this specific issue. However, I would strongly argue that "git rev-parse --no-revs --flags" is broken. I really don't have the time tonight or probably this weekend to work on it, but git-rev-parse should only take "-q" and "--quiet" for itself if "--verify" was passed. (Since that is the only mode in which rev-parse uses quiet, AFAIK.)
Possibly rev-parse should also (or instead) separate "arguments for rev-parse" and "arguments rev-parse is parsing" using the standard "--". I don't know if this will affect any current users.
~~ Brian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html