Re: [RFC PATCH 00/95] Add missing &&'s in the testsuite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 24, 2010 at 3:32 PM, Brandon Casey
<brandon.casey.ctr@xxxxxxxxxxxxxxx> wrote:
> Sounds like it should be about a 16 patch series.
>
> The first 15 patches should rework the tests that will fail when
> they are hooked together properly with &&'s.

Actually, only 9 of the tests fail when hooked together with &&'s and
needed extra fixes because of this.  4 of the tests modify the code
slightly in order to chain it together (e.g. replacing "a_command ||
return 1; command_that_fails" with "a_command && test_might_fail
command_that_fails &&"), 1 removes a stray "1" at the end of the file,
and one fixes lack of chaining by modifying tests to use
test_exit_code instead of test_expect_success (namely tests that did
nothing but check the exit code of a single command).

> And then one patch to mechanically add the missing &&'s.

Sure, I can include that change for the next round.


Thanks for the feedback.

Elijah
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]