Hi, Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes: > Jonathan Nieder writes: [snip] >> + cat >input.commit <<-EOF && >> + commit refs/heads/verify--dump-marks >> + committer $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> $GIT_COMMITTER_DATE >> + data <<COMMIT >> + test the sparse array dumping routines with exponentially growing marks > > Ok, so we want marks to grow exponentially. Just to clarify, this code is already in the tree. Jonathan is only re-indenting it and moving it inside a test_expect_success. [snip] >> + i=0 && >> + l=4 && >> + m=6 && >> + n=7 && > > Maybe use slightly less cryptic variable names? I expect these are fairly idiomatic, except maybe for 'n', which could be replaced by 'u', I guess. [snip] >> + l=$(($l + $l)) && >> + m=$(($m + $m)) && >> + n=$(($l + $n)) && > > Maybe l=$(($l * 2)) and similarly for m to emphasize that they're > doubling in every loop iteration? Hmm, $l appears twice, that's literally doubling, isn't it ;-) - Hari -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html