On Wed, Sep 22, 2010 at 19:36, Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> wrote: > On Wed, Sep 22, 2010 at 19:26, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> writes: >> >>> Oops, I didn't try running "make doc". I could write a >>> Documentation/git-sh-i18n.txt manpage, but it would probably be better >>> to just remove the patch adding it to command-list.txt, no? >> >> If it is not a documented end-user level command, it shouldn't be in the >> list. > > Ok. I've ejected that patch out for now, and fixed a two minor bugs > One NO_GETTEXT_POISON test was in the wrong patch, and I completely > removed the test that checked that $GIT_ROOT/share/locale wasn't there > under NO_GETTEXT=YesPlease from the series altogether. > > I've updated the ab/i18n ref at GitHub, you can pull that. I ran exhaustive tests on it, i.e. checked out each commit in the series and ran the whole test suite on each one, with both GETTEXT_POISON= and GETTEXT_POISON=YesPlease. That turned a few minor issues that I fixed. The result can be pulled from ab/i18n at git://github.com/avar/git.git like before. I'm *really* done fiddling with it now. At least for *this* pull request :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html