On Thu, Sep 23, 2010 at 10:35 AM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: > Since open() already sets errno correctly for the NULL-case, let's just > avoid the problematic strcmp. > > Signed-off-by: Erik Faye-Lund <kusmabite@xxxxxxxxx> I guess I should add a comment as to why this patch is needed: This seems to be the culprit for issue 523 in the msysGit issue tracker: http://code.google.com/p/msysgit/issues/detail?id=523 fetch_and_setup_pack_index() apparently pass a NULL-pointer to parse_pack_index(), which in turn pass it to check_packed_git_idx(), which again pass it to open(). This all looks intentional to my (http.c-untrained) eye. The code in mingw_open was introduced in commit 3e4a1ba (by Johannes Sixt), and the lack of a NULL-check looks like a simple oversight. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html