Han-Wen Nienhuys wrote:
>
> Hi,
>
> the git source seems full of calls similar to
>
> strncmp (x, "constant string", 15)
>
> is there a reason not to use something like
>
> int
> strxmp (char const *x, char const *y)
> {
> return strncmp (x, y, strlen (y));
> }
>
> everywhere?
If you are doing these a _lot_ then there is a significant additional
cost to using strlen on a constant string.
That said if you know its constant you can also use sizeof("foo") and
that is done at compile time. Something like:
#define strxcmp(x, y) strncmp((x), (y), sizeof((y))
-apw
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html