quoting in get_author_ident_from_commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

I wonder about the quoting done in get_author_ident_from_commit's sed
script.

It first does 's/'\''/'\''\\'\'\''/g', then 's/'\''/'\''\'\'\''/g' (the
latter once for each resulting line).
What sed actually sees is:

	s/'/'\\''/g
	s/'/'\''/g 

The second instruction only substitutes a single quote by three single
quotes because \' is just interpreted as '.

So I think just removing the three occurences of the second substitute
command just can be removed, as ''' effectively is the same as '.

Do I miss something?

(The first command was introduced in
aa66c7ec77d474b737da607d6cb2d07f56628def, the second was introduced with
git commit -m in fec3ef101c0f18bbf2400423dc70e686e9d25b0)

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]