Kirill Smelkov <kirr@xxxxxxxxxxxxxxxxxxx> writes: > (Description partly by Matthieu Moy) Better put such statements at the end, to avoid distracting the reader. > ~~~~ > > NOTE: git diff doesn't try to textconv the pathnames, it runs the > textual diff without textconv, which is the expected behavior. It's not clear whether this is intended to stay in the commit message. If not, it should go below the ---. If yes, then I'd incorporate this into the message itself. The ~~~~ and NOTE look odd. For example (in next patch): | Instead get the mode from either worktree, index, .git, or origin | entries when blaming and pass it to textconv_object() as context. | | The reason to do it is not to run textconv filters on symlinks + (just like "git diff" already does). Anyway, I'm bikeshedding. With or without these remarks, Reviewed-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html