2010/9/16 Jakub Narebski <jnareb@xxxxxxxxx>:
> On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:
>> or return;
>> while (my $line = <$fd>) {
>> my %ref_item;
>> @@ -3160,8 +3174,9 @@ sub git_get_heads_list {
>> my ($committer, $epoch, $tz) =
>> ($committerinfo =~ /^(.*) ([0-9]+) (.*)$/);
>> $ref_item{'fullname'} = $name;
>> - $name =~ s!^refs/heads/!!;
>> + $name =~ s!^refs/(head|remote)s/!!;
>>
>> + $ref_item{'class'} = $1;
>
> Is it used anywhere, or is it left to be used by a further commit in
> the series? If it is the latter, perhaps it would be worth mentioning
> in the commit message?
Actually, I think this might be a leftover from some previous
iteration (IIRC my first version of this patchset listed all heads
under 'heads' grouping them by the class defined here, whereas now we
have the two separate sections). I should probably scratch it (even
though a similar mechanism is already in place in format_ref_marker
and it might be useful to coalesce this when parsing refs)
--
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html