2010/9/17 Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>:
> On Thu, Sep 16, 2010 at 20:53, Pat Notz <patnotz@xxxxxxxxx> wrote:
>> GCC 4.4.4 on MacOS warns about potential use of uninitialized memory.
>>
>> Signed-off-by: Pat Notz <patnotz@xxxxxxxxx>
>> ---
>> dir.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/dir.c b/dir.c
>> index 133f472..d1e5e5e 100644
>> --- a/dir.c
>> +++ b/dir.c
>> @@ -232,7 +232,7 @@ int add_excludes_from_file_to_list(const char *fname,
>> {
>> struct stat st;
>> int fd, i;
>> - size_t size;
>> + size_t size = 0;
>> char *buf, *entry;
>
> What does the GCC warning say exactl? I.e. what line does it complain
> about?
>
> Maybe this is a logic error introduced in v1.7.0-rc0~25^2? I haven't
> checked.
I don't see any case that "size" can be used uninitialized. Maybe the
compiler was confused by
if (!check_index ||
(buf = read_skip_worktree_file_from_index(fname, &size)) == NULL)
return -1;
I wouldn't hurt though to initialize it early, even just to stop the
compiler from complaining.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html