On Thu, 16 Sep 2010, Giuseppe Bilotta wrote:
> git_get_heads_list(limit, class1, class2, ...) can now be used to retrieve
> refs/class1, refs/class2 etc. Defaults to ('heads') or ('heads', 'remotes')
> depending on the remote_heads option.
I like this API very much.
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
> ---
> gitweb/gitweb.perl | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7116c26..21e83bb 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3155,15 +3155,18 @@ sub parse_from_to_diffinfo {
> ## parse to array of hashes functions
>
> sub git_get_heads_list {
> - my $limit = shift;
> + my ($limit, @class) = @_;
Nitpick: @class or @classes.
> + unless (defined @class) {
> + my $remote_heads = gitweb_check_feature('remote_heads');
> + @class = ('heads', $remote_heads ? 'remotes' : undef);
Same comment as for previous patch:
+ @class = ('heads', $remote_heads ? 'remotes' : ());
Or alternative solution:
+ @class = 'heads';
+ push @class, 'remotes' if gitweb_check_feature('remote_heads');
> + }
> + my @refs = map { "refs/$_" } @class;
... or you would get
"Use of uninitialized value in concatenation (.) or string [...]"
warning when 'remote_heads" feature is disabled, isn't it?
> my @headslist;
>
> - my $remote_heads = gitweb_check_feature('remote_heads');
> -
> open my $fd, '-|', git_cmd(), 'for-each-ref',
> ($limit ? '--count='.($limit+1) : ()), '--sort=-committerdate',
> '--format=%(objectname) %(refname) %(subject)%00%(committer)',
> - 'refs/heads', ( $remote_heads ? 'refs/remotes' : '')
> + @refs
Nitpick: it is called '<pattern>...' in git-for-each-ref manpage...
> or return;
> while (my $line = <$fd>) {
> my %ref_item;
> --
> 1.7.3.rc1.230.g8b572
>
>
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html