Re: [RFC/PATCH 0/3] fast-import: give importers access to the object store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-09-04 at 22:15 -0500, Jonathan Nieder wrote:
> It works like this:
> 
> frontend:
> 	feature report-fd=3
> 	commit refs/heads/master
> 	... revision 1 ...
> 
> importer:
> 	abc7856cba76bca87a65bca76bca8bca98bca78bca76

This is probably quite a late comment, but I don't think that
'report-fd=3' is a good idea in a protocol like this.  It should not
take an argument and just respond down the appropriate selected file
descriptor.  ie, default to standard output.  If standard input is a
socket, then use that bidirectionally.  If --report-fd is used on the
command line, use that.

Sam


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]