Re: [PATCH 1/2] Command names should not be translated.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason:

I disagree with all those. These don't end up being used in a context like:

   die("git-%s: error ...", command);

But:

   die(_("Refusing to %s notes in %s (outside of refs/notes/)"),
       _(subcommand), t->ref);

You are right. I saw the first as a duplicate source of the wt-status.c command name that I got for translation. Drop these, then.

Still the construct is a bit awkward, but possibly doable, at least for my language.

These however are good, because here it gets used as:

   color_fprintf_ln(s->fp, c, _("#   (use \"git %s <file>...\" to
include in what will be committed)"), how);

I.e. this is purely a hardcoded command name.

Indeed.

--
\\// Peter - http://www.softwolves.pp.se/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]