On Sat, Sep 11, 2010 at 15:56, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> `On Mon, Aug 30, 2010 at 03:08, Jeff King <peff@xxxxxxxx> wrote:
>> I don't understand why you have these at all. Just use "git log
>> --format=%H" in your git review above (instead of rev-list), and then
>> you can just do:
>>
>> git review --grep=whatever
>> git review -Sfoo
>> git review file
>>
>> Or am I missing something subtle?
>
> You're not missing something, my alias was silly because I brainfarted
> and didn't realize I could do $@, not "$@", so now it's:
>
> review = "!f() { for rev in $(git log --reverse --format=%H $@);
> do git show $rev; done; }; f"
>
> Which means I can do all of the commands you suggested above, thanks!
Hrm, actually in the case of that alias doing:
git review -M ...
Won't do what I want, because it's `git show` that has to be invoked
by -M. An option like --for-each-invoke-pager (or something) could do
the right thing there.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html