On Fri, Sep 10, 2010 at 22:30, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> +C: >> + >> + - Include builtin.h at the top, it'll pull in in gettext.h, which >> + defines the gettext interface. > > Hmm, I would have thought that <git-compat-util.h> would be a much more > natural place for this kind of thing, not <builtin.h>. Shouldn't you be > able to write a non-builtin Porcelain if you wanted to? I don't know, I just put it in builtin.h for the builtin/*.c commands, the rest of the porcelain stuff should all have gettext.h already. Maybe gettext.h should be in git-compat-util.h, I don't know. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html