On Thu, Sep 09, 2010 at 02:39:32PM -0500, Brandon Casey wrote: > > Definitely something we should be doing, but one nit: > > > >> diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh > >> index 61de8a2..620cd02 100755 > >> --- a/t/t4018-diff-funcname.sh > >> +++ b/t/t4018-diff-funcname.sh > >> @@ -40,6 +40,11 @@ do > >> ! ( git diff --no-index Beer.java Beer-correct.java 2>&1 | > >> grep "fatal" > /dev/null ) > >> ' > >> + test_expect_success "builtin $p wordRegex pattern compiles" ' > >> + ! ( git diff --no-index --word-diff \ > >> + Beer.java Beer-correct.java 2>&1 | > >> + grep "fatal" > /dev/null ) > >> + ' > > > > Why the subshell? Shouldn't just testing the pipeline outcome work? > > Notice the similarity between the added lines and the lines just > above them? Where were you when I submitted those? :) I did. I almost said "obviously you copied from above, but that is no excuse". So let me say it now. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html