On Thu, Sep 09, 2010 at 02:02:48PM -0500, Brandon Casey wrote: > This adds fortran xfuncname and wordRegex patterns to the list of builtin > patterns. The intention is for the patterns to be appropriate for all > versions of fortran including 77, 90, 95. The patterns can be enabled by > adding the diff=fortran attribute to the .gitattributes file for the > desired file glob. The rest of your series looks reasonable, modulo the comments I posted to individual patches. But I won't torture my eyes by trying to actually see how well this matches fortran code, and just assume this is a good change. :) > This also adds a new macro named iPATTERN which is just like the PATTERNS > macro except it sets the REG_ICASE flag so that case will be ignored. Style nit: please keep macros all uppercase. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html