I added the test and used git-sendemail again, but I guess it ended up in a different thread. Is this good enough or is there some formal path that I should take? Any help appreciated. On Wed, Sep 8, 2010 at 11:04 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > davi.reis@xxxxxxxxx writes: > >> Here is how to reproduce the bug: >> >> git init >> mkdir prefix && touch prefix/a && git add prefix/a >> mkdir prefixdir && touch prefixdir/b && git add prefixdir/b >> git commit -a -m "If -r is not given, ls-tree should not show files in subdirs." >> git ls-tree --name-only HEAD prefix # works as expected >> git ls-tree --name-only HEAD prefixdir # works as expected >> git ls-tree --name-only HEAD prefix prefixdir # shows file, not dir > > That's so close to a real test-case... You should incorporate this in > your patch (e.g. in t/t3101-ls-tree-dirname.sh), to make sure such bug > never happens again. > > -- > Matthieu Moy > http://www-verimag.imag.fr/~moy/ > -- []s Davi de Castro Reis -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html