On Wed, Sep 8, 2010 at 12:47 PM, Johannes Sixt <j6t@xxxxxxxx> wrote: > On Mittwoch, 8. September 2010, Elijah Newren wrote: >> Patch and description looks good to me...however, I was a little >> surprised to see no testsuite addition or additional explanation. Are >> you seeing some t9350 tests fail on some platform despite passing on >> linux? > > Yes, I see the problem in t9350 on Windows. It is impossible to write a test > for it because the test would depend on the unspecified behavior of qsort. Makes sense. Would it be worth briefly mentioning Windows in the commit message? Either way, Acked-by: Elijah Newren <newren@xxxxxxxxx> > BTW, I don't know whether the diff machinery guarantees to produce 'C' and 'R' > records in this order. If there is no such guarantee, then fast-export would > have been broken even before 060df62. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html