On 09/08/2010 10:12 AM, Ævar Arnfjörð Bjarmason wrote: > On Mon, Sep 6, 2010 at 07:41, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> There are a few leftover bits in 'next' that need to be merged to 'master' >> before we declare a real -rc cycle, so tonight's pushout is -rc0. > > One thing that's almost certainly wrong in v1.7.3-rc0 is the NO_REGEX > defaults. It's a non-issue for people who run the configure script, > but the Makefile probably has the wrong defaults on some obscure > platforms. > > I've CC'd people involved in Tru64, UnixWare, SCO, HP/UX, IRIX etc. It > would be really useful if you could: > > 1. Get v1.7.3-rc0 > 2. Compile with the defaults, and NO_REGEX=YesPlease > 3. Run `cd t && ./t7008-grep-binary.sh` and report the results. > > That test is probably failing on some of these platforms. Yes, I've already tested and IRIX does indeed need to use the compat regex, i.e. IRIX needs NO_REGEX=YesPlease. > Alternatively, just check for REG_STARTEND in regex.h (or the includes > it pulls in): > > $ grep REG_STARTEND /usr/include/regex.h > #define REG_STARTEND (1 << 2) Unfortunately, IRIX actually defines REG_STARTEND in its regex.h, but the feature does not seem to work. This also means the configure script will give a false negative and indicate that NO_REGEX should _not_ be set, when it actually should be. I have a few other patches, in addition to this NO_REGEX setting, that I haven't found time to submit, but my feelings won't be hurt if someone else beats me to it. (hint, hint :) -Brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html