2010/9/7 Jonathan Nieder <jrnieder@xxxxxxxxx>: > This test is from 2007, which is late enough for the style to be > recognizably modern but still a while ago. Freshen it up to > follow new best practices: > > - guard setup commands with test_expect_setup, so errors at > that stage can be caught; > - use <<\EOF in preference to <<EOF, to save reviewers the > trouble of looking for variable interpolations; > - use test_cmp instead of test "$foo" = "$bar", for better > output with -v on failure; > - indent commands in subshells and let them span multiple lines; > - combine the two "gitdir required mode" tests that do not make > as much sense alone. > > Cc: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Looks good to me. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html