We have many invocations of string_list_* functions in the code that are already run with our test suite, and breakage to string_list functions would very likely break them. This patch adds yet another and a lot simpler caller that is not used from anywhere. Sorry, but I simply do not see the point. As I already said in a previous message, your program, because it is so short and simple, may be a lot easier example for people who are learning git API than any of the real existing programs. It might be a good public service to give it a wider exposure by having it somewhere in my tree than burying it in your blog ;-), but then I think a better place to do so would be in Documentation/technical/api-*.txt and not in "test program" that is not used by anything. Or are you planning to change the implementation of string_list so drastically real soon now that you need a specific test that only checks the API? If that is the case, I am Ok with treating it just like test-date which tries to test the approxidate API in isolation, but then you would need to connect test-string-list to a t/tNNNN-XXXX.sh script in the test suite. But for that purpose, you are not exercising the API to any meaningful depth yet. It uses the unordered append interface to add only two elements, does a single look up, and clear. It may be a good start, but it isn't yet something I would want to be CC'ed for application. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html