Re: [PATCH 12/15] gettextize: git-revert mark the "me" variable for translation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason wrote:

> The "me" variable is used in many later messages to indicate whether
> we're using revert or cherry-pick.

What good does it do to translate it?  The command name is the same
even in Hindi git.

> --- a/builtin/revert.c
> +++ b/builtin/revert.c
> @@ -552,7 +552,9 @@ static int revert_or_cherry_pick(int argc, const char **argv)
>  	struct rev_info revs;
>  
>  	git_config(git_default_config, NULL);
> -	me = action == REVERT ? "revert" : "cherry-pick";
> +	/* TRANSLATORS: This is used in several error messages indicating
> +	   the name of the current program */
> +	me = action == REVERT ? N_("revert") : N_("cherry-pick");
>  	setenv(GIT_REFLOG_ACTION, me, 0);

Unrelated question: Are reflog actions supposed to be translated?  (I
have not thought about that carefully.)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]