On Sun, Sep 5, 2010 at 10:13 AM, Elijah Newren <newren@xxxxxxxxx> wrote: > diff --git a/cache-tree.c b/cache-tree.c > index c60cf91..2ba6a76 100644 > --- a/cache-tree.c > +++ b/cache-tree.c > @@ -2,6 +2,7 @@ > #include "tree.h" > #include "tree-walk.h" > #include "cache-tree.h" > +#include "diff.h" /* FIXME: for tree_entry_interesting; maybe it should be in tree-walk.h? */ Yes, please. And I'd rather see it done sooner than later, before tree_entry_interesting() usage is spread over the place. Elijah Newren (2): Add testcases showing how pathspecs are ignored with rev-list --objects Make rev-list --objects work together with pathspecs Nguyễn Thái Ngọc Duy (2): tree-walk: copy tree_entry_interesting() as-is from tree-diff.c tree-walk: actually move tree_entry_interesting() to tree-walk.c list-objects.c | 25 ++++++++++ revision.c | 8 ++- revision.h | 3 +- t/t6000-rev-list-misc.sh | 51 +++++++++++++++++++ tree-diff.c | 121 ++-------------------------------------------- tree-walk.c | 110 +++++++++++++++++++++++++++++++++++++++++ tree-walk.h | 3 + 7 files changed, 201 insertions(+), 120 deletions(-) create mode 100755 t/t6000-rev-list-misc.sh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html