Re: [RFC PATCH 05/15] read_tree_recursive: Avoid missing blobs and trees in a sparse repository

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 4, 2010 at 8:00 PM, Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote:
> On Sun, Sep 5, 2010 at 10:13 AM, Elijah Newren <newren@xxxxxxxxx> wrote:
>> @@ -119,6 +119,11 @@ int read_tree_recursive(struct tree *tree,
>>                default:
>>                        return -1;
>>                }
>> +
>> +               if (git_sparse_pathspecs &&
>> +                   sha1_object_info(entry.sha1, NULL) <= 0)
>> +                       continue;
>> +
>
> I suppose this is temporary and the final solution would have stricter
> checks (i.e. only ignore if those entries are outside sparse zone)?
> This opens a door for broken repo.

Yes, good catch.  Looks like I somehow missed that one, but I agree,
there should be an "&& !tree_entry_interesting(...)" in there.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]