On Thu, Sep 2, 2010 at 20:28, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Ævar Arnfjörð Bjarmason wrote:
>
>> The only change is the removal of two messages that didn't really
>> belong: _("#\t") and _("%-20s%s\n").
>
> Hmm, isn't it better to let translators tweak the output format to fit
> their constraints? Especially 20 characters might not be enough to
> hold the "deleted by them" et al messages in some language.
Maybe, but my current mode of operation is "do it really simple and
stupid now, solicit complaints later".
Eventually I'd rather just eliminate the need for tweaking stuff like
that by having some va_args function that spews out "16" for that
given a bunch of arguments, i.e. (pseudocode):
int width = gimme_longest(
_("both deleted:"),
_("added by us:"),
_("deleted by them:"),
_("added by them:"),
_("deleted by us:"),
_("both added:"),
_("both modified:")
);
char *fmt = concat("%-", width + 4, "s%s\n");
printf(fmt, ...)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html