Thiago Farina <tfransosi@xxxxxxxxx> writes:
>>risk causing broken builds?
> Hum, how such trivial change can cause that?
Imagine if we had this in help.c:
int cmd_version(int argc, const char **argv, const char *prefix)
{
printf("git version %s\n", GIT_VERSION);
return 0;
}
which were compiled with this rule in Makefile:
help.o: help.c GIT-VERSION-FILE
and then you moved the function to a new file without touching the
dependency. Especially because the change is trivial (just moving a
function from here to there), you don't immediately notice the broken
dependency.
I just spent 15+ minutes explaining this to you (and another 10+ minutes
checking that the above is _not_ the actual case before giving the same
explanation to you last night). Now is this still a trivial change that
costs nothing?
>>What did we gain through this exercise? Did we fix any real problem?
> All patches should just fix real problems?
There is a "cost vs benefit" ratio you need to consider.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html