Re: [PATCH 1/3 v2] tests: factor HOME=$(pwd) in test-lib.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> On Tue, Aug 31, 2010 at 07:42, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
>> On Mon, Aug 30, 2010 at 23:15, Matthieu Moy <Matthieu.Moy@xxxxxxx> wrote:
>>> The same pattern is used in many tests, and makes it easy for new ones to
>>> rely on $HOME being a trashable, clean, directory.
>>>
>>> Signed-off-by: Matthieu Moy <Matthieu.Moy@xxxxxxx>
>>> ---
>>> Just re-ordered the patch to make this one the first.
>>>
>>> I took Ævar's suggestion of using $TRASH_DIRECTORY instead of $(pwd).
>>
>> Thanks,
>>
>> Acked-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
>
> Junio: FYI you picked up v1 of this for next/pu, not this v2.

I know.

The originals all used $(pwd) as far as I saw, and it _is_ more faithful
and correct refactoring not to use $TRASH_DIRECTORY in this patch, no?
You can choose to change it to use $TRASH but that should be done in a
separate patch.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]