Junio C Hamano venit, vidit, dixit 31.08.2010 18:44:
> Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes:
>
>>>> + if (!parent || parse_commit(parent->item) || parse_tree(parent->item->tree) ||
>>>> + hashcmp(parent->item->tree->object.sha1, tree_sha1)) {
>>>
>>> I didn't check, but I can imagine you can drop the parse_tree here. We
>>> should know the object sha1 once the commit is parsed.
>>
>> parse_commit() does a lookup_tree() but I don't think that it parses the
>> tree, i.e. I don't hink it fills in tree->object.sha1.
>
> Huh? parse_tree(tree) calls read_sha1_file(tree->object.sha1) to parse
> the tree. How can it do without filling tree->object.sha1?
>
Sure parse_tree() does that. That's why I call it. I never claimed it
doesn't.
Michael
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html