On Wed, Sep 01, 2010 at 12:49:18AM +1000, Jon Seymour wrote:
> In two recent series, I introduced tests that use test_must_fail incorrectly.
>
> In effect, I was calling:
>
> test_must_fail "foo bar"
>
> but this was failing because "foo bar" is not comamnd and not because
> the command "foo" fails with arguments "bar".
>
> These two patches fix these problems.
I grepped around and I think you got all of the cases. I think we can
catch this in the test harness itself, though, with the following
series:
[1/2]: tests: make test_must_fail more verbose
[2/2]: tests: make test_must_fail fail on missing commands
With this series, I get (on pu):
$ ./t1503-rev-parse-verify.sh -v -i
[...]
eval: 9: git rev-parse --verify master@{4}: not found
test_must_fail: command not found: git rev-parse --verify master@{4}
not ok - 7 master@{n} for various n
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html