Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > On Mon, Aug 23, 2010 at 19:58, demerphq <demerphq@xxxxxxxxx> wrote: > > Select "pickaxe" in the drop down on the perl5 gitweb, and then search > > for PERL_STRLEN_ROUNDUP > > > > The url generated is: > > > > http://perl5.git.perl.org/perl.git?a=search&h=HEAD&st=pickaxe&s=PERL_STRLEN_ROUNDUP > > > > Currently its running for me, and obviously wed prefer that we dont > > have N-gazillion people doing the search at once.... > > > > Ah, it just finished... Same problem. I get the error: > > > > XML Parsing Error: no element found > > Location: http://perl5.git.perl.org/perl.git?a=search&h=HEAD&st=pickaxe&s=PERL_STRLEN_ROUNDUP > > Line Number 81, Column 1: > > > > And the last couple of lines of the HTML are: > > > > </td> > > <td class="link"><a > > href="/perl.git/commit/7a9b70e91d2c0aa19f8cec5b0f8c133492a19280">commit</a> > > | <a href="/perl.git/tree/7a9b70e91d2c0aa19f8cec5b0f8c133492a19280">tree</a></td> > > </tr> > > <tr class="light"> > > > > seems to me like it timed out while searching.... > > > > Makes me think the search logic would work better as an incremental > > asynchronous fetch.... > > Ah, sounds like it's running a really expensive operation and then > running into the cgi time execution limit on the webserver (or maybe > in gitweb), so when the connection closes the browser ends up with > invalid XHTML. > > An async fetch would only make sense in that case if your gitweb and > webserver timeouts made sense, i.e. the gitweb timeout was say 1-2 sec > less than the webserver timeout. Ah, modern gitweb supports incremental blame, in that it seeds the view with file contents, then runs "git blame --incremental" in background on server and updates 'blame_incremental' view with JavaScript, but does not support incremental pickaxe. Perhaps we could borrow code from git-browser? By the way, gitweb should have caching real soon now (TM)... :-) -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html