Re: [PATCH] tests: factor HOME=$(pwd) in test-lib.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 30, 2010 at 09:50, Matthieu Moy <Matthieu.Moy@xxxxxxx> wrote:
> The same pattern is used in many tests, and makes it easy for new ones to
> rely on $HOME being a trashable, clean, directory.

Looks good, but why not:

> +HOME=$(pwd)
> +export HOME

This instead:

HOME=$TRASH_DIRECTORY
export HOME

Looks like it might be more correct given this (always an absolute
path), but I haven't tested:

case "$test" in
/*) TRASH_DIRECTORY="$test" ;;
 *) TRASH_DIRECTORY="$TEST_DIRECTORY/$test" ;;
esac
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]