Re: [PATCH 10/13] transport-helper: implement marks location as capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Heya,

On Sun, Aug 29, 2010 at 20:31, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> This seems fragile to me: shouldn't the remote helper check somehow
> that the line it read was actually a gitdir line?

You're probably right, the simplest way would be to check if repo.gitdir is set.

> No other complaint on my part.  Requiring a flush seems entirely
> appropriate to me, and if someone comes up with something nicer than
> the "capabilities" sequence for requesting information, it would not
> be the end of the world to have two ways to discover the .git dir.

Agreed.

-- 
Cheers,

Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]