Heya,
On Sun, Aug 29, 2010 at 16:36, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Hmm, I am not too happy with the long loop without explicit condition.
> Maybe it would make sense to split out the loop body as its own function?
> Something like
>
> struct ref *ref = remote_refs;
> for (;;) {
> recvline(data, &buf);
> if (!buf.len)
> break;
>
> push_update_ref_status(&buf, &ref, remote_refs);
> }
Ok, will fix.
>> strbuf_release(&buf);
>> - return 0;
>> + return;
>
> Not necessary, I think.
Removed the return.
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
>
> Thanks for a pleasant read.
Thanks for reading :).
--
Cheers,
Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html