Ilari Liusvaara <ilari.liusvaara@xxxxxxxxxxx> writes: > On Sun, Aug 22, 2010 at 12:30:00AM -0700, Junio C Hamano wrote: >> >> * il/rfc-remote-fd-ext (2010-08-14) 6 commits >> - Fix build on Windows >> - Simplify send_git_request() >> - Rewrite bidirectional traffic loop >> - gitignore: Ignore the new /git-remote-{ext,fd} helpers >> - New remote helper: git-remote-ext >> - New remote helper git-remote-fd >> >> I haven't heard anything about this series. Is it desirable? Or is it >> not used by anybody and just another baggage we'd rather not carry? > > Well, as said in series introduction, some possible uses: > - ssh with odd options without editing ssh_config (this ocassionally pops up > on #git, especially with keypair setting, dunno how much of that is > XY-problem and how much is not). > - TLS-tunneling git://. > - etc... > > And yes, I use it a lot internally. I was looking at the diff while merging the series to 'next', and noticed extra includes to two newly created files. Perhaps this should go on top or squashed to the series. builtin/remote-ext.c | 5 ----- builtin/remote-fd.c | 5 ----- 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/builtin/remote-ext.c b/builtin/remote-ext.c index d861f0a..3f8f8d5 100644 --- a/builtin/remote-ext.c +++ b/builtin/remote-ext.c @@ -1,11 +1,6 @@ #include "git-compat-util.h" #include "transport.h" #include "run-command.h" -#include <errno.h> -#include <stdlib.h> -#include <string.h> -#include <stdio.h> -#include <unistd.h> /* * URL syntax: diff --git a/builtin/remote-fd.c b/builtin/remote-fd.c index d27a7a2..22bf048 100644 --- a/builtin/remote-fd.c +++ b/builtin/remote-fd.c @@ -1,10 +1,5 @@ #include "git-compat-util.h" #include "transport.h" -#include <errno.h> -#include <stdlib.h> -#include <string.h> -#include <stdio.h> -#include <unistd.h> /* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html