Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes: > On Thu, Aug 26, 2010 at 9:50 AM, Elijah Newren <newren@xxxxxxxxx> wrote: >>> While at it, can you please also fix its comments? The comments say >>> pathspec while what it uses is actually path prefix... >>> ... >>> - * Is a tree entry interesting given the pathspec we have? >>> + * Is a tree entry interesting given the path prefix we have? >> >> I believe the comment is parsed thus: "tree entry" == combination of >> desc, base, and baselen... So I believe the original was >> correct, though I can see how it's confusing at first. > > Pathspec as in match_pathspec() in dir.c allows wildcards... > > There is also a GSoC suggestion about this [1] and I posted a related > patch a while back [2] but forgot it until now. > > [1] https://git.wiki.kernel.org/index.php/SoC2010Ideas#Unify_Pathspec_Semantics > > [2] http://mid.gmane.org/1243240924-5981-1-git-send-email-pclouds@xxxxxxxxx As [1] you quoted says, both are called pathspecs and because our longer term goal is to unify them, I think the original comment is fine. I wonder why I was Cc'ed on this shed-coloring committee, though... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html