Re: Fix 'git log' early pager startup error case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 25, 2010 at 12:16 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> The only difference is that after the user dismisses the pager, the error
> message is lost.  I am not sure if that is a problem, though.

No, there's a much more annoying difference. You mentioned it, but ignored it.

The "user dismisses the pager" part.

That's ANNOYING. I made a damn typo, my command line was bogus. I
don't want that pager. I don't want to have to press 'q' to get out of
the pager just to fix the mistake I made. I didn't ask for a pager in
the first place, and git isn't really outputting any data, so having
the pager there is wrong.

Having the pager there when git actually outputs pages and pages of
data is right. I think the "use pager by default" is absolutely the
right design decision. But that doesn't mean that we should use the
pager when there is no data output, just a command line mistake.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]