On Wed, Aug 25, 2010 at 2:31 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- > > Isn't there any rationale for this change? "args.depth > 0 does not > necessarily mean we are in a shallow clone situation, because ..." or > "using args.depth > 0 to check if we are in a shallow clone breaks under > such and such conditions and here is a test case to reproduce the bug"? .. because args.depth=0 is now also a shallow clone situation, i.e. a valid depth too. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html